Closed imacocco closed 1 month ago
Attention: Patch coverage is 71.56863%
with 29 lines
in your changes are missing coverage. Please review.
Project coverage is 81.38%. Comparing base (
24c4c60
) to head (c73691b
). Report is 12 commits behind head on main.:exclamation: Current head c73691b differs from pull request most recent head 5b07199
Please upload reports for the commit 5b07199 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
dadapy/_utils/id_estimation.py | 57.69% | 11 Missing :warning: |
dadapy/id_discrete.py | 54.54% | 10 Missing :warning: |
dadapy/id_estimation.py | 84.37% | 5 Missing :warning: |
dadapy/data.py | 84.21% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Actually, another issue might be related to the plotting functions in the tests. Do we really need to plot while testing?
I force a noninteractive backend in matplotlib in the test modules in order not to slow down the testing process
Rebased. Merging after tests pass.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.