sissa-data-science / DADApy

Distance-based Analysis of DAta-manifolds in python
https://dadapy.readthedocs.io/
Apache License 2.0
103 stars 18 forks source link

add kstar-gride id estimator and basic test #87

Closed AldoGl closed 1 year ago

AldoGl commented 1 year ago

Proposed changes

A first implementation of the Gride estimator coupled with a kstar estimation of the optimal scale.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 98.57% and project coverage change: +0.82 :tada:

Comparison is base (84f6f2a) 80.58% compared to head (4fba0fc) 81.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== + Coverage 80.58% 81.40% +0.82% ========================================== Files 10 10 Lines 1447 1506 +59 ========================================== + Hits 1166 1226 +60 + Misses 281 280 -1 ``` | [Impacted Files](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [dadapy/data.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2RhdGEucHk=) | `98.07% <97.50%> (-1.93%)` | :arrow_down: | | [dadapy/\_utils/utils.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L191dGlscy91dGlscy5weQ==) | `64.33% <100.00%> (+3.76%)` | :arrow_up: | | [dadapy/id\_estimation.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2lkX2VzdGltYXRpb24ucHk=) | `84.05% <100.00%> (+1.15%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.