Closed vdeltatto closed 1 year ago
Patch coverage: 60.00
% and project coverage change: -0.31
:warning:
Comparison is base (
c93d472
) 81.40% compared to head (4386d27
) 81.10%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @vdeltatto, great work! This is indeed a very valuable addition to the package.
Flak8 highlights the following errors
I will suggest some specific code changes to take care of them
I re-defined the argument k for the methods of the class MetricComparisons as the order of the farthest neighbour considered, instead of computing the imbalance using only the neighbour of order k. I also added two new methods
return_inf_imb_causality
andreturn_inf_imb_causality_target_rank
in the MetricComparisons class in order to compute the Imbalance of the causal test (weight*X(t), Y(t)) -> Y(t+tau). Since in this case it is difficult to use a single data set as input of the constructor of MetricComparisons, the data sets X(t), Y(t) and Y(t+tau) are given in input directly to the these additional methods. If you think that it is worth to create a new class for the causality methods, I can do it and give these data sets as input of the class constructor.In the
test
folder I added a new npy file to test the functions (intest_information_imbalance.py
)