sissa-data-science / DADApy

Distance-based Analysis of DAta-manifolds in python
https://dadapy.readthedocs.io/
Apache License 2.0
99 stars 16 forks source link

'Return_id_scaling_2NN' now works when the class is initalized with only distance matrices #92

Closed diegodoimo closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 87.71% and project coverage change: +0.45 :tada:

Comparison is base (c93d472) 81.40% compared to head (6afcfed) 81.85%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ========================================== + Coverage 81.40% 81.85% +0.45% ========================================== Files 10 10 Lines 1506 1538 +32 ========================================== + Hits 1226 1259 +33 + Misses 280 279 -1 ``` | [Impacted Files](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [dadapy/id\_estimation.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2lkX2VzdGltYXRpb24ucHk=) | `84.92% <87.27%> (+0.86%)` | :arrow_up: | | [dadapy/\_utils/utils.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L191dGlscy91dGlscy5weQ==) | `64.33% <100.00%> (ø)` | | | [dadapy/data.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2RhdGEucHk=) | `98.07% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/92/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

AldoGl commented 1 year ago

Thanks @diegodoimo, great enhancement, and I also like the 'single_scale' vs 'multiscale' division and naming.

If you have done all you wanted to do I think we could rebase and merge. Let me know!

diegodoimo commented 1 year ago

Great we can rebase