sissa-data-science / DADApy

Distance-based Analysis of DAta-manifolds in python
https://dadapy.readthedocs.io/
Apache License 2.0
99 stars 16 forks source link

added cython version for data_overlap #97

Closed diegodoimo closed 11 months ago

diegodoimo commented 11 months ago

I added a cython implementation of the data_overlap function. This makes this method which was quite slow for large datasets much faster.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 41.86% and project coverage change: -0.36% :warning:

Comparison is base (3d3c4d4) 80.46% compared to head (8fa530d) 80.10%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================== - Coverage 80.46% 80.10% -0.36% ========================================== Files 14 14 Lines 2375 2393 +18 ========================================== + Hits 1911 1917 +6 - Misses 464 476 +12 ``` | [Files Changed](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [dadapy/\_utils/density\_estimation.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L191dGlscy9kZW5zaXR5X2VzdGltYXRpb24ucHk=) | `74.52% <ø> (ø)` | | | [dadapy/\_utils/discrete\_functions.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L191dGlscy9kaXNjcmV0ZV9mdW5jdGlvbnMucHk=) | `73.36% <ø> (ø)` | | | [dadapy/id\_discrete.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2lkX2Rpc2NyZXRlLnB5) | `79.54% <ø> (ø)` | | | [dadapy/metric\_comparisons.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L21ldHJpY19jb21wYXJpc29ucy5weQ==) | `65.87% <22.22%> (-1.97%)` | :arrow_down: | | [dadapy/id\_estimation.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2lkX2VzdGltYXRpb24ucHk=) | `83.59% <63.63%> (-1.33%)` | :arrow_down: | | [dadapy/base.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2Jhc2UucHk=) | `85.56% <100.00%> (-0.30%)` | :arrow_down: | | [dadapy/clustering.py](https://app.codecov.io/gh/sissa-data-science/DADApy/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFkYXB5L2NsdXN0ZXJpbmcucHk=) | `90.85% <100.00%> (+0.07%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.