search

sissaschool / turborvb

Quantum Monte Carlo package, TurboRVB
https://turborvb.sissa.it
GNU General Public License v3.0
28 stars 6 forks source link

Fix openmp #42

Open addman2 opened 1 year ago

addman2 commented 1 year ago

Fix problem with OpenMP. CPU only.

addman2 commented 1 year ago

This is strange that it failed, I need to investigate this.

kousuke-nakano commented 1 year ago

Dear Oto,

Merge pull request #29 from kousuke-nakano/devel-#24 https://github.com/sissaschool/turborvb/actions/runs/4967748101 Yes, this is strange. The zgemm failed :-(

On May 14, 2023, at 1:21, addman2 @.***> wrote:

This is strange that it failed, I need to investigate this.

— Reply to this email directly, view it on GitHub https://github.com/sissaschool/turborvb/pull/42#issuecomment-1546703832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7IYQNHHBT75UT4QDVM4SDXF6YITANCNFSM6AAAAAAYASKRCI. You are receiving this because your review was requested.

kousuke-nakano commented 9 months ago

Dear @addman2, did you pinpoint the problem?

kousuke-nakano commented 3 months ago

Dear @addman2 , I will investigate this problem if you have not solved it. Let me know :-)

addman2 commented 3 months ago

Hi Kosuke,

it was partly solved. When turbo is compiled with the old build system (actually new build system based on makefile it was completly redesigned) the problem disappeared. I wrote the makefile build system to solve this issue. So now we know the problem is somewhere in CMake. I need to do careful comparision between those two to find where is the problem.

Towards end of this week I will be more free so I can look at it again.

kousuke-nakano commented 2 months ago

Dear @addman2, thanks!!! Let me know if there is something I can contribute to.