sissaschool / turborvb

Quantum Monte Carlo package, TurboRVB
https://turborvb.sissa.it
GNU General Public License v3.0
29 stars 6 forks source link

Fix cmake build #6

Closed addman2 closed 1 year ago

addman2 commented 1 year ago

I had to do some reverts. Library qlapack is technically always serial, but it depends on library common that is not serial/parallel agnostic. Therefore for clean build I had to introduce qlapack(-serial/-mpi). Clean solution would be if we get rid of all dependencies on common. There are two sources of these dependencies. One is getting yes_ontarget, this can be fix easilly as this can be passed to wrappers as the last argument. The second is more tricky, the lapack part of qlapack uses workspace and it is directly accessing them through modules.

Clean solution would be here to pas a context. With a context there is a minor issue that it cannot be defined in a module. But we can can do assumed shape data structure that can by compiled through include directive or through preprocessor.