Progress in refactoring code and implementing unit tests

[kousuke-nakano]

What I am doing right now are:

• Adding intent(in, out, inout) statements,
• Adding use only statements, and
• Switching the bracket convention to the star convention in the declaration (e.g. real(8) -> real*8).
• Implementing unit tests for the updated codes if possible.

In this pull request, I have changed several codes in /src/m_common/

• WIP
• IntelOneAPI installation did not properly work (temporarily).

12

[michele-casula]

Hi all,

I think the bracket convention is more used, or at least is the one I have seen used more often in the most recent fortran codes.

Ciao Michele

On Sat, Sep 30, 2023 at 4:29 PM kousuke-nakano @.***> wrote:

@.**** commented on this pull request.

In src/m_common/upsim.f90 https://github.com/sissaschool/turborvb/pull/82#discussion_r1341968524:

@@ -17,9 +17,15 @@ subroutine upsim(amat, ndim, ind, value, symmagp, ipf) use allio, only: nelorb_at, pfaffup, kiontot implicit none

• integer ndim, ndimh, ind, i, j, ipf
• real(8) amat(ndim, *), value
• logical symmagp
• ! argument parameters
• integer, intent(in) :: ndim, ind, ipf
• real(8), intent(in) :: value

Dear @addman2 https://github.com/addman2, sure! I will use the star convention in all sources. I will fix it during the ongoing refactoring process.

— Reply to this email directly, view it on GitHub https://github.com/sissaschool/turborvb/pull/82#discussion_r1341968524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBETJC3LTZE2MLJNYKK3LX5AUGDANCNFSM6AAAAAA5HJPHRM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[kousuke-nakano]

Dear @michele-casula, yes, you are right. The bracket one seems newer. Dear @addman2, we can use the bracket one, what do you think? As you pointed out, we should be careful about the complex case, i.e., complex(8) = complex*16.