search

sissbruecker / linkding-extension

Companion extension for linkding
MIT License
149 stars 32 forks source link

Edge: Omnibox / address bar not show some bookmarks #31

Open DHS1001 opened 1 year ago

DHS1001 commented 1 year ago

hi there,

When trying to search using Omnibox / address bar in Edge, some saved bookmarks are not displaying. Some examples are as follows:

https://www.isms.online/iso-27001/annex-a-11-physical-and-environmental-security/ https://info-savvy.com/iso-27001-annex-a-11-physical-and-environmental-security/

Using "ISO" and "annex" bring no results in Edge. Just wondering how the search works and is there anything I need to set to make this searchable?

linkding: 1.16.0 (latest) extention: 1.4

Thanks

sissbruecker commented 1 year ago

Can confirm it doesn't work in Chrome either (which Edge is based on). Debugging the extension it seems that Chrome converts the suggestions provided by the extension into XML, and then chokes on some characters like &, which it tries to convert into a HTML character entity reference:

Bildschirmfoto 2023-01-16 um 15 39 39

Since the XML is generated by Chrome itself, that looks like a bug in Chrome 😕. The extension provides suggestions through a JS callback, where no XML is involved: https://github.com/sissbruecker/linkding-extension/blob/575a1f036b9343777885f2ae1aa91238957a8f98/src/background.js#L34-L38

For reference, the same works fine in Firefox:

Bildschirmfoto 2023-01-16 um 15 27 20

DHS1001 commented 1 year ago

@sissbruecker Thanks for the detail analysis, it is a bit painful where edge/chrome has this kind of issue/bug. I am trying to find the pattern, some links are working: https://learn.microsoft.com/en-us/power-platform/power-fx/data-types can be searched by "microsoft" and "data" for example.