search

sissbruecker / linkding

Self-hosted bookmark manager that is designed be to be minimal, fast, and easy to set up using Docker.
https://linkding.link/
MIT License
6.63k stars 316 forks source link

Error importing bookmarks #18

Closed ericmoon closed 4 years ago

ericmoon commented 4 years ago

Running in a docker from hub.docker.com: sissbruecker/linkding:latest | pulled on 2020-04-07 15:16:52

I can't seem to get the import to work. I've tried exporting from Firefox and Chrome, but always the same error: An error occurred during bookmark import.

Any pointers to enabling error logs on the docker instance? If I was running the dev setup, I would enable the debug logs in django settings, but want to avoid that, if possible and keep it within docker.

sissbruecker commented 4 years ago

Hey @ericmoon , thanks for the report, I'll try to reproduce when I find some time.

As for logging, I just looked at the code and it looks like the error is caught but not logged 😬. So that would have to be improved as well.

bohrium272 commented 4 years ago

Hey @sissbruecker I was able to narrow down the issue to KeyError being raised while importing bookmarks, because of the absence of certain attributes in the tag.

I have opened #20 that addresses this

sissbruecker commented 4 years ago

The root cause should be fixed thanks to @arpitgogia . I also added some error handling and logging around the importer. I updated the Docker image with the fixes.

I'll close this for now, please reopen if the issue persists.