valid URL containing an underscore cannot be added

sissbruecker / linkding

Self-hosted bookmark manager that is designed be to be minimal, fast, and easy to set up using Docker.

https://linkding.link/

MIT License

6.49k stars 306 forks source link

valid URL containing an underscore cannot be added #206

Open gingerbeardman opened 2 years ago

gingerbeardman commented 2 years ago

From #202

Confirming a valid URL containing an _ (underscore) cannot be added to the system

Screenshot

Example URLs

Bug

So there is a problem with the process of checking a URLs, as both of the above are valid.

sissbruecker commented 2 years ago

Yeah, URL validation is not perfect, and from what I understand this is quite opinionated. For now linkding just uses the default Djanog URL validator, so you could also report it there. As a workaround linkding provides an option to disable URL validation: https://github.com/sissbruecker/linkding/blob/master/docs/Options.md#ld_disable_url_validation

gingerbeardman commented 2 years ago

Django won't fix, since 10 years

https://code.djangoproject.com/ticket/18517

gingerbeardman commented 1 year ago

I'm here one year later trying linkding again (thanks to Browser Companion app for iOS/macOS) and these two URLs failed to import again, not that I expected it to have changed.

~~I'm trying a workaround encoding the underscore as %5F~~

I was able to add them as wayback machine versions.

https://web.archive.org/web/20230504175240/http://infoseek_rip.g.ribbon.to/crspalm.hp.infoseek.co.jp/

😄