sissbruecker / linkding

Self-hosted bookmark manager that is designed be to be minimal, fast, and easy to set up using Docker.
MIT License
5.32k stars 261 forks source link

Would you like to get some of the features from my fork? #729

Closed vslinko closed 1 month ago

vslinko commented 1 month ago

I made some features for myself:

Maybe something might be interesting to merge into the original repo? I could make a fully functional PR with good UI, tests, etc.

sissbruecker commented 1 month ago

Thanks, those look useful. Some thoughts:

vslinko commented 1 month ago

Preview lazy loading: Makes sense, regarding implementation it should be possible to use the loading attribute on the image though: https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading#images_and_iframes

I prefer JS implementation because Safari loads all the lazy images in the background. The lazy attribute just lowers the priority.

If there's a UX problem, I'm fine with it getting fixed, though a bug issue with some context would help

If you click on a link on mobile (I tried on iOS), then go back, the link will be in focus and the tooltip will overlap half of the link, which is annoying because it's hard to take the focus off on mobile.

vslinko commented 1 month ago

Thanks for the feedback, I'll think about how to make good PRs.