search

sissbruecker / linkding

Self-hosted bookmark manager that is designed be to be minimal, fast, and easy to set up using Docker.
https://linkding.link/
MIT License
6.7k stars 318 forks source link

Removing a bookmark does not remove its related image preview #883

Open JamesMenetrey opened 1 month ago

JamesMenetrey commented 1 month ago

Dear author,

I noticed a behaviour that may be a bug for Linkding.

When the feature Preview Images is enabled, and a bookmark is created and then removed, the related preview image (in the previews directory) is not removed.

As an observation, when the feature Automatically create HTML snapshots is enabled, I acknowledge that creating and removing a bookmark properly deletes the related snapshot files, indicating that the deletion task is executed, despite the preview image file remains.

I could replicate this behaviour on a clean installation of Linkding with a single bookmark, easing to notice that the preview image file is not deleted once the bookmark is removed.

I believe that removing a bookmark should delete the corresponding preview image, as it is no longer used afterwards.

Thanks and cheers!

sissbruecker commented 3 weeks ago

Thanks, that is indeed missing at the moment.