[02-01] Signup to be part of their network

sita-samoa / sita-membership

VILT (Vue.js, Inertia.js, Laravel, Tailwind CSS) repo for SITA Membership Database

MIT License

5 stars 22 forks source link

[02-01] Signup to be part of their network #16

Closed ainsofs closed 1 year ago

ainsofs commented 1 year ago

02-01 As a member I want to signup to be part of their network (mail lists, announcements, etc.)

est 6 hrs

westerandr commented 1 year ago

@ainsofs im thinking we might need to break this down into sub-tasks. It is a big one.

Multi-step form
Validation and File uploads
State Management maybe
Lots of UI work

ainsofs commented 1 year ago

Sure good idea. Pls link them to this issue. Also is there a reason u keep moving tickets back to to do instead of in progress?

westerandr commented 1 year ago

Seki, maybe we can have discussions on how to break it down properly as I am not an expert with laravel and vue. Also sorry I think I might be doing that by accident 😂

ainsofs commented 1 year ago

todo

[x] member validation
[x] member save to db
[x] qualification validation #43
[x] qualification save to db #43
[x] support doc validation #44
[x] support doc save to db #44
[x] work experience validation #46
[x] work experience save to db #46
[x] referee validation #47
[x] referee save to db #47
[x] read look ups from db (title, gender, mail lists, countries, membership type)

ainsofs commented 1 year ago

Hi @westerandr and @Green-Ranger11 . Pls check if progress ok to merge. If so leave a comment and I will merge as I want to update the squash commit message

westerandr commented 1 year ago

@ainsofs malo! really nice pr. Everything looks good to me. If I may suggest one thing. It would be to move the Welcome component on the dashboard page to the sign up page, and have the welcome component as the initial rendered component and when sign up button is clicked, the multi-form/tabbed form is shown.

How would we be able to hide or restrict the user that hasn't signed up yet from the dashboard, and other pages etc. except for sign up page and whatever pages they need to see to check pending membership status.

I know that this is a big ticket, so still a lot of work to do but so far, this is a very good base to branch off on and work on sub tickets. Good stuff uso!

encode685 commented 1 year ago

Malo lava @ainsofs, this was a big pr. Just a few questions plz. Does a user's sign up details get saved after clicking Next on each step or only when it gets submitted? At the moment it only seems to get saved when its submitted. All data is lost when refreshing the page. Just working on adding work experience details but need a member_id to link it to.

westerandr commented 1 year ago

Thats a good option. Another approach would also be to save in local storage? Not sure how this would be with file uploads, maybe those could go to a temp folder, until form is completed then move to the actual folder the file will go to, Just one option out of many! Updating the member table and its related tables upon each step is still okay.

ainsofs commented 1 year ago

It’s added after first step. Then updated for each other step.

ainsofs commented 1 year ago

Check this suggestion from @encode685

[x] change input type to 'number' for Year attended
[x] link the added qualification to a member_id. If you change the member_id in the url, the added qualification is showing for all members rather than just the member that added it
[ ] move the error messages near the field they refer to. Atm it's showing above the label of the next field

ainsofs commented 1 year ago

First 2 items are addressed. Will add 3rd item as a ticket. Should be a matter of updating the inputerror component classes