sitcomlab / Ethics-app

Ethics-application for the approval of user-studies
http://giv-ethics-app.uni-muenster.de
MIT License
2 stars 8 forks source link

Member login fail counter not resetting #55

Open SpeckiJ opened 5 years ago

SpeckiJ commented 5 years ago

The App tracks failed login attempts from members here https://github.com/sitcomlab/Ethics-app/blob/de7f31ec74339874ed51305b9da7dcd61b0ee07f/controllers/member_login.js#L116

The Account is automatically blocked once there were 6 failed login attempts here: https://github.com/sitcomlab/Ethics-app/blob/de7f31ec74339874ed51305b9da7dcd61b0ee07f/controllers/member_login.js#L74

This "fails" variable (aka Database column) is never cleared automatically (e.g. once a day) and there is no way to manually reset the counter from inside the app. Once there were 5 login attempts in a lifetime of the member, the account is permanently blocked.

Desired behaviour: Allow X login attempts a day Current behaviour: Allow X failed attempts a lifetime