site24x7 / terraform-provider-site24x7

Terraform provider for Site24x7
MIT License
22 stars 33 forks source link

Add Canada to DataCenter #249

Closed MarcHenriot closed 4 months ago

MarcHenriot commented 4 months ago

Hi,

Our team and I require support for the Canadian datacenter in your Terraform provider. I’ve already forked the project, and if you’re interested, we’d like to discuss merging this feature.

As of today, we added the below changes to site24x7/data_center.go.

package site24x7

var dataCenter = map[string]DataCenter{
...
    "CA": {
        displayName:          "Canada",
        code:                 "CA",
        site24x7APIBaseURL:   "https://www.site24x7.ca/api",
        zohoAccountsTokenURL: "https://accounts.zohocloud.ca/oauth/v2/token",
    },
}

We’ve made changes to the documentation in multiple locations where we previously mentioned (US/EU/…) to now include (US/EU/…/CA). Additionally, we’ve updated the docs/index.md file to reflect the new provider documentation.

Let us know if there are any missing changes.

Thanks !

jim-billy-zoho commented 4 months ago

@MarcHenriot Thank you for your contribution to Site24x7 Terraform Provider.

MarcHenriot commented 4 months ago

Hey @jim-billy-zoho, sorry for the mix-up with the documentation #250. Thanks a lot for the quick review!

jim-billy commented 4 months ago

Not an issue @MarcHenriot. Thank you!