sitecrafting / conifer

:evergreen_tree: A powerful WordPress library plugin for OO development
https://www.coniferplug.in
MIT License
18 stars 2 forks source link

Bugfix/search #114

Closed acobster closed 5 years ago

acobster commented 5 years ago

Ticket: #108

Issue

SupportsAdvancedSearch can trigger database errors in some cases, such as when running admin queries, or when custom clauses are added to the query (and thus meta_key is not a unique column).

Solution

Detect edge cases and default settings to support (hopefully) all use-cases.

Impact

Stabilizes the search API.

Usage Changes

None.

Considerations

None.

Testing

Passes e2e tests (this isn't very unit-testable as-is).