search

sitecrafting / conifer

:evergreen_tree: A powerful WordPress library plugin for OO development
https://www.coniferplug.in
MIT License
18 stars 2 forks source link

Introduce PHPStan and fix level 0 problems #132

Closed szepeviktor closed 3 years ago

szepeviktor commented 3 years ago

@acobster What do you think?

I know-I know. I've broken PHP 7.0 compat :(

szepeviktor commented 3 years ago

Strange that the Timber 2 branch contains "timber/timber": "^1.7" 🤔

acobster commented 3 years ago

Thanks for working on this!

Strange that the Timber 2 branch contains "timber/timber": "^1.7"

Strange indeed. Once we get a Timber 2.x beta release we can switch over to that. In the meantime feel free to change this to 2.x-factories which has the latest changes we need. Some tests will probably still fail for now. I've been testing this in a pretty ad-hoc way in a downstream project for now using the bleeding edge versions of Timber and Conifer which is why Conifer itself is going to need some love before too long. See also #131

I'm fine with requiring PHP 7.1 or even higher in the Conifer beta, since Timber 2.x is a breaking change anyway. We're probably going to use at least 7.1 on Timber.

szepeviktor commented 3 years ago

I'm fine with requiring PHP 7.1 or even higher in the Conifer beta

Done :)

szepeviktor commented 3 years ago

I let you raise PHPStan level as commented in phpstan.neon.dist.