search

sitecrafting / conifer

:evergreen_tree: A powerful WordPress library plugin for OO development
https://www.coniferplug.in
MIT License
18 stars 2 forks source link

Improve Travis configuration #133

Closed szepeviktor closed 3 years ago

szepeviktor commented 3 years ago

Going through the whole config, improving everything: consistency, readability, fix problems.

szepeviktor commented 3 years ago

Could we run on NodeJS 12?

acobster commented 3 years ago

Yes, feel free to upgrade Lando and the node version.

acobster commented 3 years ago

FYI @szepeviktor I'm considering replacing the whole Cypress suite with WP_UnitTestCases over on #119, like we have in Timber. End-to-end is just the wrong level of abstraction for this, I think. So I wouldn't worry too much about running Lando in CI going forward.

szepeviktor commented 3 years ago

Okay, I leave this PR up to you.

acobster commented 3 years ago

Good enough for rock 'n' roll. We will need to follow up and fix doc builds but these improvements are useful on their own for now.