Update android packages

sitefinitysteve / nativescript-google-analytics

Apache License 2.0

23 stars 14 forks source link

Update android packages #10

Closed guillaume-roy closed 8 years ago

guillaume-roy commented 8 years ago

The actual versions of packages are incompatible with other nativescript plugins at build time.
- Especially the + notation : compile 'com.google.android.gms:play-services-analytics:+'
- In my case the issue was with @EddyVerbruggen 's nativescript-plugin-firebase plugin.
It seems that the latest version of com.android.tools.build:gradle is 2.1.0 but when nativescript-cli creates android platform the version is 1.5.0 and in your plugin it's 2.0.0-beta6. In doubt, i didn't change it, it's just for your information.

guillaume-roy commented 8 years ago

Hello ?

sitefinitysteve commented 8 years ago

I'll merge today

On Aug 1, 2016 8:32 AM, "Guillaume ROY" notifications@github.com wrote:

Hello ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sitefinitysteve/nativescript-googleanalytics/pull/10#issuecomment-236567880, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6Nxl-4mZVv_3vBv7wxwLoWEUXVG9ks5qbedDgaJpZM4JH2Qs .

guillaume-roy commented 8 years ago

Thanks !

sitefinitysteve commented 8 years ago

Updated on npm now

Sorry about this, HONESTLY... I saw the email, but didn't see it was a PR :)

guillaume-roy commented 8 years ago

No problem. I remembered that yesterday.