NPM version outdated?

[SBD580]

Hi,

Is it possible that the version found in NPM although at 0.3.2 still include a specific version of google-services?

Shay

[sitefinitysteve]

It's all listed here https://github.com/sitefinitysteve/nativescript-google-analytics/blob/master/plugin/platforms/android/include.gradle

On Dec 29, 2016 5:15 PM, "SBD580" notifications@github.com wrote:

Hi,

Is it possible that the version found in NPM although at 0.3.2 still include a specific version of google-services?

Shay

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sitefinitysteve/nativescript-google-analytics/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6L1i2tarbZX0FEKnjr5KKYsGKiu5ks5rNDDjgaJpZM4LX4XS .

[SBD580]

Hi @sitefinitysteve thanks for the super quick response. I can see at the source code that the version is the latest (aka '+') but when using npm to download the plugin as a dependency, looking at the file got downloaded under node_modules I see a specific version of google-services (9.2.0)

[SBD580]

Maybe it has something to do with the

// [START gms_compile]
// [END gms_compile]

which I'm not familiar with. Is that some kind of a placeholder or something?

[sitefinitysteve]

Hmmm, let me check on this

On Dec 29, 2016 5:19 PM, "SBD580" notifications@github.com wrote:

Hi @sitefinitysteve https://github.com/sitefinitysteve thanks for the super quick response. I can see at the source code that the version is the latest (aka '+') but when using npm to download the plugin as a dependency, looking at the file got downloaded under node_modules I see a specific version of google-services (9.2.0)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sitefinitysteve/nativescript-google-analytics/issues/22#issuecomment-269702439, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6BWU09klxAtW6wr3KFEe-DZA2xw7ks5rNDHqgaJpZM4LX4XS .

[elliottohara]

The NPM version still has google-services(9.2.0)

[sitefinitysteve]

Yeah sorry I'm away with no laptop to check it out

On Jan 3, 2017 10:19 PM, "elliottohara" notifications@github.com wrote:

The NPM version still has google-services(9.2.0)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sitefinitysteve/nativescript-google-analytics/issues/22#issuecomment-270286364, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6MzvX283boI3hVPhBEZ4CYrZk7mLks5rOw-9gaJpZM4LX4XS .

[ignaciolarranaga]

Another one here seeing the same problem, in the source it says:

dependencies {
    // [START gms_compile]
    compile 'com.google.android.gms:play-services-analytics:+'
    // [END gms_compile]
}

But when you download the module from npm it says:

dependencies {
    // [START gms_compile]
    compile 'com.google.android.gms:play-services-analytics:9.2.0'
    // [END gms_compile]
}

In my case it was also producing errors in other plugins (check: https://github.com/NativeScript/push-plugin/issues/76). I just corroborate if I place '+' instead of 9.2.0 it gets resolved.

[sitefinitysteve]

I bumped the version to 3.3 and republished, can you try now?

On Sun, Jan 8, 2017 at 4:08 PM, Ignacio Larrañaga notifications@github.com wrote:

Another one here seeing the same problem, in the source it says:

dependencies { // [START gms_compile] compile 'com.google.android.gms:play-services-analytics:+' // [END gms_compile] }

But when you download the module from npm it says:

dependencies { // [START gms_compile] compile 'com.google.android.gms:play-services-analytics:9.2.0' // [END gms_compile] }

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sitefinitysteve/nativescript-google-analytics/issues/22#issuecomment-271179561, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6L5oa5WhywrutDqsmMQ6PahgJN8nks5rQVA2gaJpZM4LX4XS .

[ignaciolarranaga]

Fixed. Thanks!

[SBD580]

Thanks!