search

sitefinitysteve / nativescript-google-analytics

Apache License 2.0
23 stars 14 forks source link

Allow override version of play services #23

Closed SBD580 closed 7 years ago

SBD580 commented 7 years ago

Hi,

When trying to apply "com.google.gms.google-services" (apply plugin: "com.google.gms.google-services"), which other plugin is doing (nativescript-plugin-firebase) I'm getting this error:

A problem occurred evaluating script.
> Failed to apply plugin [id 'com.google.gms.google-services']
   > For input string: "+"

Please allow override the version of play services with a project variable (googlePlayServicesVersion) which is already in used in several other plugins. for example:

https://github.com/EddyVerbruggen/nativescript-plugin-firebase/blob/master/platforms/android/include.gradle https://github.com/dapriett/nativescript-google-maps-sdk/blob/master/platforms/android/include.gradle

Thanks

SBD580 commented 7 years ago

I have submited a PR

sitefinitysteve commented 7 years ago

Thanks, I'll bump the version and publish npm shortly

On Tue, Jan 10, 2017 at 10:20 AM, SBD580 notifications@github.com wrote:

Hi,

When trying to apply "com.google.gms.google-services" (apply plugin: "com.google.gms.google-services"), which other plugin is doing ( nativescript-plugin-firebase https://github.com/EddyVerbruggen/nativescript-plugin-firebase) I'm getting this error:

` A problem occurred evaluating script.

Failed to apply plugin [id 'com.google.gms.google-services'] For input string: "+" `

Please allow override the version of play services with a project variable (googlePlayServicesVersion) which is already in used in several other plugins. for example:

https://github.com/EddyVerbruggen/nativescript- plugin-firebase/blob/master/platforms/android/include.gradle https://github.com/dapriett/nativescript-google-maps-sdk/ blob/master/platforms/android/include.gradle

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sitefinitysteve/nativescript-google-analytics/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6Gv-mA7-Zew7EeOQVWuB_tlezViiks5rQ6GigaJpZM4Lfh5D .

SBD580 commented 7 years ago

@sitefinitysteve just in case you didn't notice, I have submitted a fixed PR

sitefinitysteve commented 7 years ago

I know sorry dude, I just didn’t have a chance to publish yet

From: SBD580 [mailto:notifications@github.com] Sent: January 11, 2017 12:40 PM To: sitefinitysteve/nativescript-google-analytics nativescript-google-analytics@noreply.github.com Cc: Steve McNiven-Scott steve@sitefinitysteve.com; Mention mention@noreply.github.com Subject: Re: [sitefinitysteve/nativescript-google-analytics] Allow override version of play services (#23)

@sitefinitysteve https://github.com/sitefinitysteve just in case you didn't notice, I have submitted a fixed PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sitefinitysteve/nativescript-google-analytics/issues/23#issuecomment-271937285 , or mute the thread https://github.com/notifications/unsubscribe-auth/ABeI6Or0af0dRpMUIyUvh8pR27i580m6ks5rRRP5gaJpZM4Lfh5D . https://github.com/notifications/beacon/ABeI6LB8E3FEcRk9qkxcKE1tKLch5Lm0ks5rRRP5gaJpZM4Lfh5D.gif