search

sitefinitysteve / nativescript-google-analytics

Apache License 2.0
23 stars 14 forks source link

Conflict w/ nativescript-google-maps-sdk plugin #8

Closed dklinzing closed 8 years ago

dklinzing commented 8 years ago

First of all, awesome plugin. Thanks for that!

Second, there seems to be a conflict between the nativescript-google-maps-sdk plugin and the nativescript-googleanalytics plugin. The nativescript-googleanalytics plugin is referencing the google play services 8.4.0 but the nativescript google maps sdk plugin is referencing the newest google play services version installed.

I talked w/ the nativescript-google-maps-sdk plugin developer @dapriett and he thought it might be best to add the following line to your plugin so it always targets the latest installed version? compile 'com.google.android.gms:play-services-maps:+'

Thoughts? Here's the issue I have on his plugin: https://github.com/dapriett/nativescript-google-maps-sdk/issues/34#issuecomment-222698981

sitefinitysteve commented 8 years ago

Can do! I'll test it today and push the update

sitefinitysteve commented 8 years ago

Need a few hours though...

dklinzing commented 8 years ago

No rush. Thank you!

sitefinitysteve commented 8 years ago

Added your + change, demo seems to still build and work, it's on NPM, let me know!

dklinzing commented 8 years ago

Awesome, thanks!