search

sitegeist / Sitegeist.Archaeopteryx

The missing link editor for Neos
MIT License
21 stars 12 forks source link

BUGFIX: Use native Neos UI Dialog for link editor #40

Closed grebaldi closed 11 months ago

grebaldi commented 1 year ago

fixes: #39

The problem

Dialog behavior in Neos UI has changed recently. Those changes collide with Sitegeist.Archaeoptryx' custom dialog implementation, which renders it unusable in the node creation dialog.

The solution

https://github.com/sitegeist/Sitegeist.Archaeopteryx/assets/2522299/58668079-c985-4f4d-babf-90dd23de2e3a

I replaced the custom dialog implementation with Neos UI's native dialog. For this I needed to (hackily) adjust the dialog's layout behavior, which lead to a follow-up PR in Neos.Neos.Ui.

crydotsnake commented 1 year ago

Could you maybe take a look at it? @nezaniel

crydotsnake commented 1 year ago

ping @mficzel / @nezaniel

mhsdesign commented 12 months ago

Thank you so much for taking care ❤️ This also fixes a bug when one tries to reedit a link from within the inspector, as the pending changes overlay will interfere:

Current dev-main https://github.com/sitegeist/Sitegeist.Archaeopteryx/assets/85400359/097ccd0e-37f6-4fd9-85e5-2e1e7e7f4eea

Your fix https://github.com/sitegeist/Sitegeist.Archaeopteryx/assets/85400359/15f92d8d-d3ab-4ed6-8945-dbf372798a69

Additionally its a nice touch to have the orange border and shake animation when trying to click outside of the dialog. Previously the dialog wouldn't close either but just stay as is.

mhsdesign commented 12 months ago

Though we have to adjust the composer json to be only compatible with neos ui patches with this fix - will do this later ;)

crydotsnake commented 11 months ago

Would be awesome, if we could get this merged :)