search

sitegeist / Sitegeist.Archaeopteryx

The missing link editor for Neos
MIT License
21 stars 11 forks source link

BUG: `relNofollow` is not applied to link #43

Open mhsdesign opened 10 months ago

mhsdesign commented 10 months ago

https://github.com/sitegeist/Sitegeist.Archaeopteryx/assets/85400359/5405e3e6-fc7f-4050-afaf-7ad8dc923abd

As far as i can tell, this

In https://github.com/sitegeist/Sitegeist.Archaeopteryx/blame/a003751455ccd6759cd6968dea11c08481ee4296/Neos.Ui/core/src/application/Dialog/Dialog.tsx#L33-L40 we filter out unsupported link options, but as we declare the field relNofollow internally with a different casing relNoFollow, we always filter it out: https://github.com/sitegeist/Sitegeist.Archaeopteryx/blob/a003751455ccd6759cd6968dea11c08481ee4296/Neos.Ui/core/src/application/Dialog/Settings.tsx#L69-L72

My thesis is that the relNofollow has never worked before.