search

sitegeist / Sitegeist.Archaeopteryx

The missing link editor for Neos
MIT License
21 stars 11 forks source link

Does not work inside RichTextEditor if validation of another property failed #56

Open lorenzulrich opened 7 months ago

lorenzulrich commented 7 months ago

If you use a property with the RichTextEditor, you cannot set a link because the link editor modal is behind the Rich Text Editor.

How to test

    foo:
      type: string
      ui:
        label: 'Foo'
        reloadIfChanged: true
        inspector:
          group: foo
          editor: 'Neos.Neos/Inspector/Editors/RichTextEditor'
          editorOptions:
            linking:
              'Sitegeist.Archaeopteryx':
                linkTypes:
                  'Sitegeist.Archaeopteryx:Node':
                    allowedNodeTypes: ['My.Site:Document.Mixin.LinkablePage']
lorenzulrich commented 7 months ago

I just realized that this only fails under one condition: A validation of another property failed in the inspector.

So, normally it works. But if validation of another property failed and you open the RichTextEditor and then you want to add a link, the Link Editor is behind the RichTextEditor:

image

I'm mentioning @mhsdesign here because he once mentioned issues with automatically triggered validation.

mhsdesign commented 7 months ago

Thanks this is interesting. It seems also the pending change overlay was triggered. So a few things seem of here ^^