search

sitegeist / Sitegeist.Archaeopteryx

The missing link editor for Neos
MIT License
21 stars 12 forks source link

BUGFIX: Prevent the node editor from breaking for nodes with hashes #60

Open rolandschuetz opened 6 months ago

rolandschuetz commented 6 months ago

Fixes #59

Benjamin-K commented 6 months ago

This will show links like node://XXXXXX#section as they are without resolving the node, right? At least the editor can be used for such links, but IMO the main goal should be to see the selected node, too. Nevertheless, this is way better than the current behavior. But the same check should then be used for assets, too.

rolandschuetz commented 6 months ago

Exactly, since there was no decision on how the UI should look, this is just a bugfix preventing an internal server error and broken UI.

Benjamin-K commented 6 months ago

Could you add asset:// links with hashes to this PR, too? That would be awesome!

rolandschuetz commented 5 months ago

@Benjamin-K Makes sense, I added it together with some tests