sitegeist / Sitegeist.LostInTranslation

Automatic Translations for Neos via DeeplApi
GNU General Public License v3.0
9 stars 9 forks source link

feat: option to (partly) prevent syncing and translation #32

Open hphoeksma opened 1 year ago

hphoeksma commented 1 year ago

Fixes: #31

gradinarufelix commented 6 months ago

Sorry for the long delay. I had a look at it now and I like the idea.

My only question is: do you think it is enough to just test the parent node? In my opinion, it has to be recursive. In other words, once I set this option on a content node, it disabled translations for all content nodes below to the n-th layer. Otherwise, you could have the following case:

If you enabled preventTranslation on the collection, it would hold for the ButtonGroup but not for the Button.

Am I right here or did I misunderstand something in your code?

hphoeksma commented 6 months ago

Hmm... the idea was that once a collection is marked as prevented, nothing in that collection is translated. But it could be I did not test / need it recursively...