sitegeist / Sitegeist.LostInTranslation

Automatic Translations for Neos via DeeplApi
GNU General Public License v3.0
9 stars 8 forks source link

FEATURE: Support glossaries #5

Open jobee opened 2 years ago

jobee commented 2 years ago

First of all, thank you for this package! I love it.

I've seen Deepl added glossary support via the API. Some projects might benefit from that... https://www.deepl.com/docs-api/managing-glossaries/

(I'll take care of it myself, as soon as a client requests it ;-))

mficzel commented 2 years ago

We would accept a pr for that or do it once a client needs that. Before that this will have to wait.

gradinarufelix commented 2 years ago

Hi @jobee,

I came up with a lightweight solution in the meantime, see PR #10. You can now define terms to be ignored. Instead of implementing the whole glossaries API, I am currently wrapping those terms using preg_replace in a <ignore> tag. I tested it and it worked so far. Happy to hear from you if that solves your case.

jobee commented 2 years ago

@gradinarufelix I like that. Ignoring terms can be very useful in some projects. However, I would leave this issue open as well.

robert-heinig commented 1 year ago

FYI: On of our customers sponsors the development of the glossary integration. My goal is to integrate this feature officially into this package.

gradinarufelix commented 1 year ago

@robert-heinig any updates on this? 😄

paavo commented 3 months ago

@robert-heinig any Update on the glossary integration?

lorenzulrich commented 2 months ago

@robert-heinig Same here, any update in the glossary integration?