search

sitegeist / fluid-components

Encapsulated frontend components with Fluid's ViewHelper syntax for TYPO3
https://fluidcomponents.sitegeist.de/
GNU General Public License v2.0
54 stars 21 forks source link

Use GifBuilder for Placeholder images instead of relying on 3rd party #119

Open sascha-egerer opened 1 year ago

sascha-egerer commented 1 year ago

Use GifBuilder to generate a local placeholder image instead of relying on a 3rd party service. This will increase reliability and may also prevent exposure of internal URLs to a third party service.

lukasniestroj commented 1 year ago

I love the idea. Maybe we can provide a solution like: https://github.com/IchHabRecht/filefill/blob/main/Classes/Resource/Handler/ImageBuilderResource.php ?

s2b commented 1 year ago

We're currently working on another that would provide responsive images (srcset/sizes and picture tag) for fluid components (and especially in the styleguide). In that context we are rethinking placeholder images.

Your PR is valuable input, thank you! However, we might need to move placeholder generation to a separate service class. We will look into it soon.

sascha-egerer commented 1 year ago

We're currently working on another that would provide responsive images (srcset/sizes and picture tag) for fluid components (and especially in the styleguide). In that context we are rethinking placeholder images.

Your PR is valuable input, thank you! However, we might need to move placeholder generation to a separate service class. We will look into it soon.

Thank you! Sounds good! should I close this PR?

s2b commented 1 year ago

FYI: This is the current status of development: https://github.com/sitegeist/media-components