search

sitegeist / sms-responsive-images

This TYPO3 extension provides ViewHelpers and configuration to render valid responsive images based on TYPO3's image cropping tool.
GNU General Public License v2.0
34 stars 18 forks source link

Bad srcset is generated for some images #45

Closed dmitryd closed 5 years ago

dmitryd commented 5 years ago

If image path contains characters like space or comma, SMS\SmsResponsiveImages\Utility\ResponsiveImagesUtility::generateSrcsetAttribute will generate invalid srcset because it does not url-encode image paths. In my case the result looked like:

srcset="/fileadmin/_processed_nextcloud_/c/7/csm_Foto_Airsec_165_97b5ee854c.jpg 160w,
/fileadmin/_processed_nextcloud_/c/7/csm_Foto_Airsec_165_a32d92bd66.jpg 320w,
/fileadmin/_processed_nextcloud_/c/7/csm_Foto_Airsec_165_7c7c4221e7.jpg 480w,
/fileadmin/_processed_nextcloud_/c/7/csm_Foto_Airsec_165_b42af5e0cf.jpg 640w,
/fileadmin/_processed_nextcloud_/c/7/csm_Foto_Airsec_165_7b9986c8a5.jpg 683w,
http://domain.test/typo3temp/fal_webdav/4/A/B/Keller, _Archive, _Lager/Foto_Airsec_165_6d4bd6dd2014c984cfa0ba40de5c420a62976bd2.jpg 943w"

Look at http://domain.test/typo3temp/fal_webdav/4/A/B/Keller, _Archive, _Lager/Foto_Airsec_165_6d4bd6dd2014c984cfa0ba40de5c420a62976bd2.jpg.