search

sitegeist / sms-responsive-images

This TYPO3 extension provides ViewHelpers and configuration to render valid responsive images based on TYPO3's image cropping tool.
GNU General Public License v2.0
34 stars 18 forks source link

[BUGFIX] added fileExtension as parameter in renderImage func, as par… #58

Closed dpool closed 4 years ago

dpool commented 4 years ago

Hi everbody! Affected installation: TYPO3 V 10.3.0

The function "renderImage" in "typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php" expects a fourth optional parameter "$fileExtension". As the function "renderImage" in "sms-responsive-images/Classes/ViewHelpers/MediaViewHelper.php" extends the main MediaViewHelper of fluid and calls its parent at the end, an error will be thrown, as this parameter is missing in the current development branch. This pull request adds the fourth optional parameter "$fileExtension" to the "renderImage" function in "sms-responsive-images/Classes/ViewHelpers/MediaViewHelper.php".

Regards

s2b commented 4 years ago

Great, thank you for your contribution! :)