search

sitegeist / sms-responsive-images

This TYPO3 extension provides ViewHelpers and configuration to render valid responsive images based on TYPO3's image cropping tool.
GNU General Public License v2.0
34 stars 18 forks source link

Namespace in image.html still the old one #73

Closed rowild closed 3 years ago

rowild commented 4 years ago

Hi!

I just updated to v2.0.2 and keep getting this error: get_class() expects parameter 1 to be object, null given in /[path]/typo3_src-9.5.21/typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php line 110

Upon reading the documentation I came accross the line that mentions that the namespace changed: The PHP namespace has switched from SMS\SmsResponsiveImages to Sitegeist\ResponsiveImages, so if you extended one of the provided PHP classes, you need to adjust this.

But looking at the image.html in this extension, the namespace is still in the old fformat: <html xmlns:sms="http://typo3.org/ns/SMS/SmsResponsiveImages/ViewHelpers" data-namespace-typo3-fluid="true">

Also, just updating from a v1 to a v2 does NOT remove the Demo folder. So reading the docu and comparing with the existing files in the extension is confusing :-)

s2b commented 3 years ago

It sounds like something went wrong in the composer (?) update process on your side. The demo folder is clearly not present in the released extension.

However, the namespace in the template file should be fixed, although the extension should work fine nontheless because of ext_localconf.php.