search

sitegeist / sms-responsive-images

This TYPO3 extension provides ViewHelpers and configuration to render valid responsive images based on TYPO3's image cropping tool.
GNU General Public License v2.0
34 stars 18 forks source link

[BUG] Attributes loading and fileExtension are not in Typo3 v.9.5 #87

Closed rupasix closed 2 years ago

rupasix commented 2 years ago

Tested on: Typo3 v9.5.31 EXT v.2.1.0 Hello! You assumed that attributes "loading" and "fileExtension" exists in "\TYPO3\CMS\Fluid\ViewHelpers\MediaViewHelper" but in typo3 v9 they don't. Viewhelper with new attributes is fired here https://github.com/sitegeist/sms-responsive-images/blob/master/Resources/Private/Extensions/fluid_styled_content/Partials/Media/Rendering/Image.html and it creates error:

Oops, an error occurred!
Undeclared arguments passed to ViewHelper Sitegeist\ResponsiveImages\ViewHelpers\MediaViewHelper: fileExtension, loading. Valid arguments are: additionalAttributes, data, class, dir, id, lang, style, title, accesskey, tabindex, onclick, alt, file, additionalConfig, width, height, cropVariant, srcset, sizes, breakpoints, lazyload, placeholderSize, placeholderInline, ignoreFileExtensions

Related commits: https://github.com/sitegeist/sms-responsive-images/commit/a74d85fa3fbcafbcac1f1c9fbcfd3e802e9e5e4f https://github.com/sitegeist/sms-responsive-images/commit/1a9a46ca68dde6e04b622b1fdebb62a356441e03

s2b commented 2 years ago

This should be fixed with v2.1.1 of the extension.