[BUGFIX] Do not set empty crop in `$processingInstructions`

sitegeist / sms-responsive-images

This TYPO3 extension provides ViewHelpers and configuration to render valid responsive images based on TYPO3's image cropping tool.

GNU General Public License v2.0

34 stars 18 forks source link

[BUGFIX] Do not set empty crop in `$processingInstructions` #93

Closed julianhofmann closed 2 years ago

julianhofmann commented 2 years ago

If there's no cropping configured, null is passed as configuration in $processingInstructions. This way, the image is not scaled at all. The patch is setting $processingInstructions['crop'] only if the configuration is not empty.

Fixes: #92

julianhofmann commented 2 years ago

This behavior, we have only when using the ViewHelper in a certain (custom) extension.

Seems to be caused by the default sizes="(min-width: %1$dpx) %1$dpx, 100vw"... After some time of debugging, I'll "fix" it by setting the needed sizes.