Fix parse error, accept header values separated without space

sitegui / nodejs-websocket

A node.js module for websocket server and client

MIT License

736 stars 155 forks source link

Fix parse error, accept header values separated without space #46

Closed hlovdal closed 5 years ago

hlovdal commented 7 years ago

The following example failed:

$ socat - TCP:localhost:1234,crnl
GET / HTTP/1.1
Connection: Upgrade,Keep-Alive
Upgrade: websocket
Sec-WebSocket-Key: hq0S1hpdldRhTHVwXBDPvg==
Sec-WebSocket-Version: 13
Host: localhost:1234

HTTP/1.1 400 Bad Request

$

but would have worked as expected with

Connection: Upgrade, Keep-Alive

hlovdal commented 5 years ago

@sitegui Is there anything missing before you can merge this?

sitegui commented 5 years ago

Hello @hlovdal , sorry for missing your PR, it got lost in my inbox.

No, it's perfect! Thanks for your contribution