sitemesh / sitemesh2

SiteMesh 2: Official repository
http://sitemesh.github.io/sitemesh2/
Other
134 stars 83 forks source link

2.6.0 - create xml, tlds for Jakarta EE 10 #44

Closed codeconsole closed 3 months ago

codeconsole commented 4 months ago

https://github.com/sitemesh/sitemesh2/tree/2.6.x/src/etc/tld https://github.com/sitemesh/sitemesh2/blob/2.6.x/src/etc/blank/WEB-INF/web.xml

rainboyan commented 4 months ago

@codeconsole https://github.com/sitemesh/sitemesh2/pull/43 should be merged first

codeconsole commented 4 months ago

@rainboyan, you updated the 1.1 tag library instead of creating a new folder like was done for 1.2

I am not against that, but we should probably remove the 1.2 folder then. Have you confirmed the tlds are bundled in the jar?

rainboyan commented 4 months ago

@codeconsole I can confirm that the tlds will be included in the jar. It's fine to remove the old versions. I will do it later.

rainboyan commented 4 months ago

@codeconsole Done. Anything else?

codeconsole commented 4 months ago

@rainboyan why did the publish plugin fail going from 2.0.0-rc-1 to 2.0.0?

https://github.com/sitemesh/sitemesh2/pull/43

rainboyan commented 4 months ago

I closed it because the two commits both changed the version of project.

It is time to release it now?

codeconsole commented 4 months ago

@rainboyan For some reason the publishing stopped working and I am not sure why.

* What went wrong:
Execution failed for task ':publishMavenJavaPublicationToSonatypeRepository'.
> Failed to publish publication 'mavenJava' to repository 'sonatype'
   > Could not PUT 'https://s01.oss.sonatype.org/content/repositories/snapshots/opensymphony/sitemesh/2.7.0-SNAPSHOT/sitemesh-2.7.0-20240701.062031-2.jar'. Received status code 401 from server: Content access is protected by token
rainboyan commented 4 months ago

@codeconsole Use generated token instead of the password

https://central.sonatype.org/faq/401-error/#answer

https://central.sonatype.org/publish/generate-token/

codeconsole commented 4 months ago

@rainboyan can you run the latest snapshot 2.6.0-SNAPSHOT jar against Grace and verify it is good to release?

rainboyan commented 4 months ago

@codeconsole I just checked the snapshot version and it works well, it's good to release now.

codeconsole commented 3 months ago

2.6.0 has been released to Maven Central