search

sitemule / ILEastic

Embedded application server for ILE on IBM i
Apache License 2.0
58 stars 29 forks source link

fixed basic auth realm not available for all threads #67

Closed m1h43l closed 5 years ago

m1h43l commented 5 years ago

With thread(concurrent) the realm variable would be created for each thread. So the executing thread would not get the value set from the user on the main thread. "static(allthread) on the realm variable fixed that.

NielsLiisberg commented 5 years ago

But then every user that access the service will be logged into that and share the credentials. Static will not do the trick - you need to put it on a cookie / session

m1h43l commented 5 years ago

No, no! It is just the realm name which is returned in the response if there is no Authorization header. Nothing more. Just some configuration.

I would like to put that into an external configuration which then would also be available to the plugins but that has to wait a little bit longer.

m1h43l commented 5 years ago

Like: WWW-Authenticate: Basic realm="User Visible Realm", charset="UTF-8"

m1h43l commented 5 years ago

If you use a browser to access the resource on the server the realm will be displayed in the login box.

NielsLiisberg commented 5 years ago

OK - Got it !! Great !!

But session management is on the TODO list ( well not now - REST is the primary goal)

On Wed, May 1, 2019 at 6:22 PM m1h43l notifications@github.com wrote:

If you use a browser to access the resource on the server the realm will be displayed in the login box.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sitemule/ILEastic/pull/67#issuecomment-488331097, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVIPHTBJFIIHSZ7D5INGZDPTG7SXANCNFSM4HJTIGGQ .