search

sitemule / ILEastic

Embedded application server for ILE on IBM i
Apache License 2.0
58 stars 29 forks source link

extended makefile and added namespace to API data structure names #9

Closed m1h43l closed 6 years ago

m1h43l commented 6 years ago

The complete API should have the namespace "il" and that should also include the data structures and also all other symbols like constants or variables.

I have updated the demos and extended the makefile a little bit. It now supports the installation of the header file in a "global" include directory so that the user only needs to specify one include directory for all applications and libraries/service programs.

m1h43l commented 6 years ago

FYI: Some files started with the hex codes: EF BB BF. This seems to be a unicode BOM (byte order mark). This renders the files unusable. I have removed these bytes.

NielsLiisberg commented 6 years ago

Great - thank you !! However we have a merge conflict, I will fix ...

worksofliam commented 6 years ago

@m1h43l

Are you able to make sure your branch is up to date with the latest commits from master? (e.g. can you resolve the conflicts).

Thanks, Liam Barry

NielsLiisberg commented 6 years ago

Done!

On Fri, Sep 14, 2018 at 10:18 AM Liam Barry notifications@github.com wrote:

@m1h43l https://github.com/m1h43l

Are you able to make sure your branch is up to date with the latest commits from master? (e.g. can you resolve the conflicts).

Thanks, Liam Barry

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sitemule/ILEastic/pull/9#issuecomment-421269588, or mute the thread https://github.com/notifications/unsubscribe-auth/ACqHnvgSQXlpaHppobGib26VsOcwoSGyks5ua2ZjgaJpZM4WZpbg .

-- Best regards

Niels Liisberg Chief Software Architect System & Method A/S Phone +45 70 20 30 10 Mobile + 45 31 15 88 61

m1h43l commented 6 years ago

I'll make a new request later.