search

siteorigin / siteorigin-panels

SiteOrigin Page Builder is a powerful content creation interface, instantly recognizable, astonishingly different. SiteOrigin Page Builder makes it easy to create responsive column-based content using the widgets you know and love. Your content will accurately adapt to all mobile devices, ensuring your site is mobile-ready.
https://siteorigin.com/page-builder/
GNU General Public License v3.0
611 stars 181 forks source link

Inline CSS generation broken - no space between style tag attributes #1180

Closed grubersjoe closed 5 months ago

grubersjoe commented 5 months ago

Hey. After I've upgraded the plugin to the latest version, generation of inline <style> tags no longer works, see below screenshot. The issue is that there's no space between the <style> tag name and its attributes like media="all" etc.:

<stylemedia="all"id="siteorigin-panels-layouts-head">
<!-- instead of --> 
<style media="all" id="siteorigin-panels-layouts-head">

Consequently, you get broken markup:

image

The regression was introduced in this commit.

~I you want I can also open up a PR.~ Done that: https://github.com/siteorigin/siteorigin-panels/pull/1181

Misplon commented 5 months ago

Hi Jonathan. Thanks for your efforts; apologies for the hassle. Alex from SiteOrigin will attend when he's next online. Cheers.