search

siteorigin / so-css

SiteOrigin CSS is the simple, yet powerful CSS editor for WordPress. It gives you visual controls that let you edit the look and feel of your site in real-time.
https://siteorigin.com/css/
GNU General Public License v2.0
46 stars 10 forks source link

Editor has problem recognizing custom properties and advnaced css rules. #166

Open numanzahid opened 1 year ago

numanzahid commented 1 year ago

Hi there,

SO-CSS had problem recognizing css variables, variable definitions and advanced css selectors. It also had problem with complicated css rules such as repeat function in grid.

SO-CSS marks all of these as false and error.

Grid Repeat Function: image Note: Does not understand gap property as well.

CSS variable definitions: image

Variable usage: image

Problem with :has selector: image

Probably there is some update to the code editor. Maybe old version of code mirror is causing these errors and warnings. Current version was released in 2017 and there are new versions available.

Hope you guys are able to fix this problem.

Have a nice day.

Misplon commented 1 year ago

Hi @numanzahid

Thanks for taking the time to get in touch. We're using the core WordPress version of CodeMirror.

https://github.com/siteorigin/so-css/pull/126

Misplon commented 1 year ago

It looks like there is a Trac ticket open at https://core.trac.wordpress.org/ticket/48456. If the situation persists, we'll re-evaluate whether to self-host CodeMirror. Thanks again for reaching out.

numanzahid commented 1 year ago

Hi @Misplon,

Thanks for the fast response. Hopefully SiteOrigin team decides to self host the CodeMirror as WordPress is not likely to change this.

On the other hand whole functionality of SO-CSS relies on its editor. Especially SO-CSS is offering premium version of this plugin as well.

Surely the self hosting will add about 3mb to the plugin but will allow you to use more CodeMirror addons and functionalities and complete control over the behavior.

Have a nice day.

Misplon commented 1 year ago

Hi, thanks for your reply.

SiteOrigin CSS is almost entirely free. The only setting that SiteOrigin Premium adds is a Web Font Selector for choosing Google Fonts. There isn't a premium version of SiteOrigin CSS, as you'd normally understand it. Just the one setting added via SiteOrigin Premium.

CodeMirror was previously included in SiteOrigin CSS. We'll reevaluate the situation with the core being updated and get back to you in the week.

Thanks again.

Andrew

Misplon commented 1 year ago

@numanzahid Apologies for the delay. We, unfortunately, haven't had a chance to move CodeMirror yet. We'll update you as soon as we've made progress.