search

siteorigin / vantage

Vantage is a flexible multipurpose theme. Its strength lies in its tight integration with some powerful plugins like Page Builder for responsive page layouts, Smart Slider 3 for big beautiful sliders and WooCommerce to help you sell online. Vantage is fully responsive and retina ready. Use it to start a business site, portfolio or online store.
https://siteorigin.com/theme/vantage/
GNU General Public License v2.0
67 stars 14 forks source link

Feature/menu alignment additional support #346

Closed Misplon closed 4 years ago

Misplon commented 4 years ago

Resolves https://github.com/siteorigin/vantage/issues/345.

@AlexGStapleton Testing for this needs to be done methodically.

Header Layout: Logo in Menu

AlexGStapleton commented 4 years ago

Looks good. Is there a specific reason for disabling the menu alignment on mobile?

Misplon commented 4 years ago

Thanks

There isn't much space available on mobile when using Logo in Menu so I thought it best. Here is what it looks like if we don't right-align the mobile button and are centering.

Screenshot 2019-12-27 at 13 55 56
AlexGStapleton commented 4 years ago

That's understandable. I do see a situation where the user is using the Mobile Menu on all devices who would want the abbility to alter the alignment, but we can always provide CSS in that situation.

Misplon commented 4 years ago

Sounds good, let's see how it goes in terms of support requests.