search

sitespeedio / chrome-har

Create HAR files from Chrome Debugging Protocol data
MIT License
150 stars 50 forks source link

Parse request cookies and response set cookies #111

Open jtung23 opened 1 year ago

jtung23 commented 1 year ago

This change properly handles the cookies and set-cookies in requestWillBeSentExtraInfo and responseReceivedExtraInfo respectively. The methods were skipping instead of finding the request entries already stored before the page loads.

My use case is puppeteer where the request structure is

  1. requestWillBeSent
  2. requestWillBeSentExtraInfo
  3. responseReceivedExtraInfo
  4. responseReceived
  5. Page.frameStartedLoading
jtung23 commented 1 year ago

lmk what you think @soulgalore!

soulgalore commented 1 year ago

Thanks @jtung23 I'll have a look this weekend.

jtung23 commented 1 year ago

Hi @soulgalore, just wanted to follow up and see if you're able to review this PR. Our team would love to be able to view cookies in the HAR for our debugging purposes! Thanks in advance!