search

sitespeedio / chrome-har

Create HAR files from Chrome Debugging Protocol data
MIT License
150 stars 50 forks source link

HAR format Cookies derived from DevTools Cookie objects have incorrect dates #122

Open UppaJung opened 1 month ago

UppaJung commented 1 month ago

https://github.com/sitespeedio/chrome-har/blob/5b076f8c8e578e929670761dcc31345e4e87103c/lib/cookies.js#L13

formatCookie can be called with cookie objects created by the tough-cookie's Cookie.parse method or by directly passing cookies in DevTools Protocol format. When cookies are in DevTools format, the expiration field is in seconds from the unix epoch, whereas dayjs interprets numeric inputs as milliseconds from the unix epoch. So, if this field is a number, it needs to be multiplied by 1000 before being passed to dayjs. Currently, cookies from DevTools format all appear to expire in the 1970s.

A minimalist fix might be (though I haven't tested it):

        : dayjs(typeof cookie.expires === "number" ? cookie.expires * 1000 : cookie.expires).toISOString(),

I discovered the issue while experimenting with porting/re-writing chrome-har in typescript and trying to replicate chrome-har's current behavior. Please feel free to compare against the typescript implementation to test the fix, or to adopt the code from it, which is also MIT license. (You're free to take the whole thing, but it's a very big change of coding style to adapt to if you don't like typescript.) Sorry that the first you are hearing from me is me filing bugs, but leaving them unreported seemed worse than the alternative.

soulgalore commented 1 month ago

Hi @UppaJung thanks for the creating the issues, I'll go over them the next weekend (5th of October) and see which bugs are fixable.