search

sitespeedio / chrome-har

Create HAR files from Chrome Debugging Protocol data
MIT License
149 stars 50 forks source link

Support multiple pages navigation #29

Closed soulgalore closed 5 years ago

soulgalore commented 5 years ago

When we navigate to two different pages (using Browsertime) we still just create one page (branch with example trace https://github.com/sitespeedio/chrome-har/tree/multi-page-har).

The problem is that we use the frame_id as the unique key when we create a page new page. But the frame_id is the same between navigation, so when we get new requests, we match that with the first page.

rriemann commented 5 years ago

How is this issue linked to #19 ?

soulgalore commented 5 years ago

Ohh this one is old, I think we actually skipped it and create one trace per navigation that makes it so much simpler. For #19 seems to be a puppeteer issue, I don't know.