search

sitespeedio / chrome-har

Create HAR files from Chrome Debugging Protocol data
MIT License
149 stars 50 forks source link

Fix missing initial redirects #59

Closed jonapgar closed 4 years ago

jonapgar commented 4 years ago

Prior to this change redirects which occur before the first page navigation are lost. I had to add addFromFirstRequest(timings,params) to ensure timing information would be passed to populateEntryFromResponse. This could probably written more clearly but would require refactoring of the timing/page logic.

soulgalore commented 4 years ago

Hi @jonapgar ah great! Can you fix the travis errors (npm run lint:fix) and if you also can add a trace file in the test dir so that we have a test case for this. So I'm sure we don't break it in the future.

Thanks!