sitespeedio / chrome-har

Create HAR files from Chrome Debugging Protocol data
MIT License
149 stars 50 forks source link

Fix initiator and update package lock #9

Closed ddadon10 closed 6 years ago

ddadon10 commented 6 years ago

Hello,

I fixed the initiator, its now have different properties according to its type property:

For all type:

Parser type:

Script type:

And I updated the package.lock.json

Thanks 😄

ddadon10 commented 6 years ago

Strange, npm run lint do not raise me any error on my machine, do I miss something ?

ddadon10 commented 6 years ago

Also, I found that the CI has failed with the precedent commit https://travis-ci.org/sitespeedio/chrome-har/jobs/322701738 too.

Do I have to change something in the code or does the CI criteria (or the linter in the code) have to be change ?

Thanks 😄

tobli commented 6 years ago

Since we don’t lock down dev dependencies, the version of prettier that’s the current at the time will be run. There are sometimes small formatting changes to prettier, so a previously green build might shift to red, just by running npm install at a later time. Not ideal, we should probably lock it down, at least to a major version.

I can have a closer look, hopefully later tonight. Changes look awesome btw. =)