Find workaround for h2 test with chrome >= 51 and node 4

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.

MIT License

1.21k stars 64 forks source link

Find workaround for h2 test with chrome >= 51 and node 4 #114

Closed beenanner closed 7 years ago

beenanner commented 8 years ago

With Chrome 51 h2 no longer works with NPN causing one of the tests to fail due to needing ALPN which is only supported in node.js >= 5.0 while using the http2 module for running tests.

soulgalore commented 8 years ago

so I guess ALPN worked in 4.4.4 but that was just luck then, I've missed that is 5 only when I added it to the project.

tobli commented 8 years ago

Since this is purely a test issue I'd say we just disable these tests on node 4. It's only 4 months until node 6 will be the LTS version, so I don't think it's worth spending too much time on.

soulgalore commented 8 years ago

sounds good.

tobli commented 7 years ago

Time heals all wounds. Or at least makes issues irrelevant once in a while.