search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

optimalCssSize: wrong error message #120

Closed XhmikosR closed 8 years ago

XhmikosR commented 8 years ago

I tested this with mpc-hc.org and chrome 50 64-bit on Windows 7 64-bit.

├─────────────────────────┼─────────────────────────────────────────────────────
──┼──────────┤
│ optimalCssSize          │ https://cdn.mpc-hc.org/assets/css/pack.71b13363.css
  │ 90       │
│                         │ size is 14.5 kB and that is bigger than the limit of
  │          │
│                         │ 14.5 kB. Try to make the CSS files fit into 14.5 kb.
  │          │
├─────────────────────────┼─────────────────────────────────────────────────────
soulgalore commented 8 years ago

Think this will make it cleaner, @XhmikosR are you able to check again?

XhmikosR commented 8 years ago

Now looks good, thanks!

XhmikosR commented 8 years ago

@soulgalore:

├────────────────────┬───────────────────────────────────────────────────────┬──────────┤
│ optimalCssSize     │ https://cdn.mpc-hc.org/assets/css/pack.71b13363.css   │ 90       │
│                    │ size is 14.5 kB (14548) and that is bigger than the   │          │
│                    │ limit of 14.5 kB. Try to make the CSS files fit into  │          │
│                    │ 14.5 kB.                                              │          │
├────────────────────┴───────────────────────────────────────────────────────┴──────────┤

I still find it weird. :/

Also, we should probably mention that size is with compression.