Closed XhmikosR closed 7 years ago
With localhost
, the tests seem to work now on Windows.
@tobli @soulgalore: any thoughts?
Guys, is something wrong with the PR? I'd like to get things going.
Hey @XhmikosR no it's fine just thinking about how we will handle this in the future. What happens if we break the build on Windows, thinking we will not be able to fix. I'll have a look at it tonight or tomorrow.
Bump
Yes lest fix this when we released 4.0, hopefully next week then :)
No interest for so long, so I'm gonna close this and I'll ditch any other local patches.
Before merging, make sure you add AppVeyor to the project, and enable "Skip branches without appveyor.yml" in settings.
I couldn't find a clean way to show the browsers' version number so I added win-detect-browsers. This worked only for Firefox, Chrome made the build stuck.
On a side note, shouldn't you test the minimum supported node.js version too (0.10 at the time of writing)? Otherwise, how will you know if it breaks?
Fixes #118. Fixes #195.