sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

Add appveyor.yml for Windows testing via AppVeyor. #123

Closed XhmikosR closed 7 years ago

XhmikosR commented 8 years ago

Before merging, make sure you add AppVeyor to the project, and enable "Skip branches without appveyor.yml" in settings.

I couldn't find a clean way to show the browsers' version number so I added win-detect-browsers. This worked only for Firefox, Chrome made the build stuck.

before_test:
  - '"C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -version>ff_version.txt && type ff_version.txt'
  - '"C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --version'

On a side note, shouldn't you test the minimum supported node.js version too (0.10 at the time of writing)? Otherwise, how will you know if it breaks?

Fixes #118. Fixes #195.

XhmikosR commented 8 years ago

With localhost, the tests seem to work now on Windows.

https://ci.appveyor.com/project/XhmikosR/coach/history

XhmikosR commented 8 years ago

@tobli @soulgalore: any thoughts?

XhmikosR commented 8 years ago

Guys, is something wrong with the PR? I'd like to get things going.

soulgalore commented 8 years ago

Hey @XhmikosR no it's fine just thinking about how we will handle this in the future. What happens if we break the build on Windows, thinking we will not be able to fix. I'll have a look at it tonight or tomorrow.

XhmikosR commented 8 years ago

Bump

soulgalore commented 8 years ago

Yes lest fix this when we released 4.0, hopefully next week then :)

XhmikosR commented 7 years ago

No interest for so long, so I'm gonna close this and I'll ditch any other local patches.